fix: treat CTRL + J as Enter
#832
Conversation
|
I don't think hardcoding the binding like this is the right move, even if I can see it being part of the default binding. If you use the kitty keyboard extensions it may be possible to bind the true |
|
I use Wezterm, so maybe there's some configuration I need to investigate there. I'm not currently aware of a way to rebind keys like that in Wezterm, but admittedly I haven't looked. |
|
Thinking about this, IIRC editors like Neovim are often interested in exposing CTRL + J as a separate binding from The application I want to "fix" this in is Nushell; perhaps I should contribute there instead? It is my observation elsewhere that Nushell understands that it's receiving a CTRL + J. |
|
Ah, looks like I can resolve this with Nushell configuration: nushell/nushell#6427 (comment) 🫡 Guess I'm done here, sorry for the noise! |
This resolves the issue I noted having in nushell/nushell#6427 (comment), where hitting
Enterin MacOS and Linux outside the mainReedline::read_linecall in raw mode results in a CTRL + J event that yields no actual input onceread_lineis called again.I'm not positive that this doesn't introduce regressions with, e.g., pasted input. I'm not sure what the best way to test this would be.
I'm also not sure if it resolves that issue in its entirety, since the question of whether its scope should include
\nis unresolved.